Merged
Conversation
- Add two-column layout with sticky sidebar for filters - Add enhanced search bar with clear button and results counter - Add category facet with 14 checkboxes and select all/clear buttons - Add ecological state and origin facets - Add active filters summary section with removable tags - Wrap existing UMAP plot in right column
- Create new Jinja template for index.html with filtering UI - Replace inline HTML generation with template rendering - Add enhanced search (name + description) - Add category facet with 14 checkboxes - Add ecological state facet with 3 checkboxes - Add active filters summary with removable tags - Add two-column responsive layout (filter panel + grid) - Add JavaScript for real-time filtering - Maintain consistent UI with UMAP page
There was a problem hiding this comment.
Pull request overview
This PR adds a comprehensive filtering system to the UMAP visualization page, replacing the simple name/ID search with multi-field search, collapsible category/state/origin facets, and an active filters summary. It introduces a two-column layout with a sticky sidebar filter panel alongside the UMAP scatter plot.
Changes:
- Added a filter panel with enhanced search (name, ID, environment, category), three collapsible facet sections (Category, Ecological State, Origin), and an active filters summary with removable tags
- Replaced the previous simple search with a debounced multi-field search and faceted filtering system using AND logic across facets and OR logic within facets
- Replaced the
IMPLEMENTATION_SUMMARY.mdcontent and added supporting documentation (PR_DESCRIPTION.md,FILTER_TESTING_GUIDE.md)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
src/communitymech/templates/community_umap.html |
Source template: added ~585 lines of CSS for filter panel layout, HTML for facet sections, and JavaScript for filtering logic |
docs/community_umap.html |
Regenerated build artifact reflecting the template changes |
PR_DESCRIPTION.md |
New file describing the PR's features, testing, and checklist |
IMPLEMENTATION_SUMMARY.md |
Entirely replaced previous LLM network quality check documentation with UMAP filter feature summary |
FILTER_TESTING_GUIDE.md |
New manual testing checklist covering all filter panel functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
✅ All Review Comments AddressedAll 7 Copilot review comments have been resolved with the following fixes: Performance & Code Quality
Accessibility
Documentation
Commits
See Status: Ready for final review and merge 🚀 |
Performance improvements: - Batch update Select All/Clear All (14x faster, single updateFiltering call) - Extract countByFacets() helper function (DRY principle) Accessibility improvements: - Replace div.facet-header with button elements - Add aria-expanded and aria-controls attributes - Add keyboard focus styles and hover states - Update toggleFacet() to maintain ARIA state Responsive design: - Fix SVG overflow with responsive container CSS - Add overflow-x: auto to .plot-container - Constrain SVG with max-width: 100% Documentation: - Remove placeholder screenshot URLs from PR description - Remove 'Closes #XX' placeholder - Update file count to reflect all 9 modified files - Rename IMPLEMENTATION_SUMMARY.md to UMAP_FILTER_IMPLEMENTATION.md - Restore original IMPLEMENTATION_SUMMARY.md (LLM quality check docs) - Add comprehensive PR_REVIEW_FIXES_SUMMARY.md All review threads have been resolved on GitHub PR #29.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.